@mappum I'm beginning to think it might be good to allow a Height of 0. It is representative of something meaningful: a chain in a state before it has produced an initial block, which in particular would help resolve this issue without making invasive changes to Tendermint KMS:

tendermint/tmkms#369

(also note I'm the one to blame for disallowing a height of 0, so I assume there's probably not going to be a lot of debate if you do change it as part of this PR)

@tarcieri I added the 0-height change.

However, it's still hard to use the integration tests because there are various differences between responses on different chains. It would be nice if it could be tested against an easy-to-spin-up local testnet (e.g. tendermint node --proxy_app=kvstore), since testing against gaiad has the external requirement of figuring out what network it should be on. Currently, gaiad for Cosmos mainnet is on an older version of Tendermint, so I'm not sure if there's some gaia testnet that the integration tests target.

I added the 0-height change.

Great!

However, it's still hard to use the integration tests because there are various differences between responses on different chains.

Yeah it's been a big pain point in the past. If you can think of a better strategy (particularly one that works in CI) I'd be all for it.

I would vote for either making the integration test run something like this:

tendermint init --home=/some/tmp/dir
tendermint node --home=/some/tmp/dir --proxy_app=kvstore # (or counter or something)

(Then remove the Tendermint data after the tests run).

This could either run a tendermint binary included in this repo, or download it from Github releases (it could use the system's installed tendermint but this would mean people may run tests against the wrong version and have to worry about managing it themselves).

Until then, we could change the integration tests to target this kind of network but still expect the user to run it manually.

@mappum there's a bit of prior art for this with the test harness used by the KMS:

• https://github.com/tendermint/kms/blob/master/Dockerfile
• tendermint/tmkms@5427d0f

You could potentially try to use the same Docker image on CircleCI?

@tony-iqlusion I can make that change in a later PR, for now I changed the integration tests to pass when using a local node for a throwaway network. Are you OK with merging this change? (I'd very much like to use this fix so I can use the RPC client).

I realized the encoding for the response should be changed too, since Tendermint always converts the key and value fields to base64 strings (but the request is in hex, lol).

Let me know if I should make any other changes.

@mappum looks like it needs a GPG signature

Signed last commit.

@mappum looks like it requires all commits to be signed. Perhaps squash and sign the resulting commit.

Made the changes, will wait to squash so it's easier to review.

Now all comments are addressed and all commits signed.